chore: update MessageVersionData for service compatibility #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmandM
reviewed
Aug 28, 2024
| @@ -567,14 +566,29 @@ private void SendConnectionRequest() | |||
| if (MessageManager.MessageTypes[index] != null) | |||
| { | |||
| var type = MessageManager.MessageTypes[index]; | |||
| message.MessageVersions[index] = new MessageVersionData | |||
| var messageVersionData = new MessageVersionData | |||
There was a problem hiding this comment.
This whole group of logic feels like it maybe would make sense on the data structure?
Something like two constructors, one that is for DistributedAuthorityMode == false and takes the hash and the version, and one that is for DistributedAuthorityMode == true that takes the type and the version, and then calculates the hash internally. That way if the type is important, the hash can never be wrong. That would also mean the logic of do we or do we not send the type is better encapsulated and consistent.
There was a problem hiding this comment.
Hmmm... let me fiddle with that idea...seems a bit cleaner indeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass of sending
ILPPMessageProvider.NetworkMessageTypeswhen using a distributed authority network topology.Changelog
NA
Testing and Documentation